[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-pm
Subject:    Re: [PATCH] cpufreq: intel_pstate: Fix missing return statement
From:       "Rafael J. Wysocki" <rafael () kernel ! org>
Date:       2020-09-30 15:39:01
Message-ID: CAJZ5v0i+KJxS=GKCP8r-5XJ7mnKLAo2hU3fNgFYXush=NrViUw () mail ! gmail ! com
[Download RAW message or body]

On Mon, Sep 28, 2020 at 4:36 PM Zhang Rui <rui.zhang@intel.com> wrote:
>
> From 1027ed2cacb0b50676eb52dd0089076d951033d7 Mon Sep 17 00:00:00 2001
> From: Zhang Rui <rui.zhang@intel.com>
> Date: Mon, 28 Sep 2020 11:33:42 +0800
> Subject: [PATCH] cpufreq: intel_pstate: Fix missing return statement
>
> Fix missing return statement when writing "off" to intel_pstate status
> sysfs I/F.
>
> Fixes: 55671ea3257a ("cpufreq: intel_pstate: Free memory only when turning off")
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> ---
>  drivers/cpufreq/intel_pstate.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index a827b000ef51..9a515c460a00 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -2781,6 +2781,7 @@ static int intel_pstate_update_status(const char *buf, size_t size)
>
>                 cpufreq_unregister_driver(intel_pstate_driver);
>                 intel_pstate_driver_cleanup();
> +               return 0;
>         }
>
>         if (size == 6 && !strncmp(buf, "active", size)) {
> --

Applied as a 5.9-rc fix, thanks!
[prev in list] [next in list] [prev in thread] [next in thread]