[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-pcmcia
Subject:    Re: [PATCH 2/5] Dynamic ID addition doesn't need get_driver()
From:       Jiri Kosina <jkosina () suse ! cz>
Date:       2012-02-01 13:15:45
Message-ID: alpine.LNX.2.00.1202011415250.18918 () pobox ! suse ! cz
[Download RAW message or body]

On Tue, 24 Jan 2012, Alan Stern wrote:

> As part of the removal of get_driver()/put_driver(), this patch
> (as1511) changes all the places that add dynamic IDs for drivers.
> Since these additions are done by writing to the drivers' sysfs
> attribute files, and the attributes are removed when the drivers are
> unregistered, there is no reason to take an extra reference to the
> drivers.
> 
> The one exception is the pci-stub driver, which calls pci_add_dynid()
> as part of its registration.  But again, there's no reason to take an
> extra reference here, because the driver can't be unloaded while it is
> being registered.
> 
> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
> CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> CC: Jiri Kosina <jkosina@suse.cz>
> CC: Jesse Barnes <jbarnes@virtuousgeek.org>
> CC: Dominik Brodowski <linux@dominikbrodowski.net>

Acked-by: Jiri Kosina <jkosina@suse.cz>

for the drivers/hid part. Thanks,

-- 
Jiri Kosina
SUSE Labs

_______________________________________________
Linux PCMCIA reimplementation list
http://lists.infradead.org/mailman/listinfo/linux-pcmcia
[prev in list] [next in list] [prev in thread] [next in thread]