[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-pcmcia
Subject:    [PATCH] remove incorrect and redundant modprobe modalias rule
From:       Colin Watson <cjwatson () ubuntu ! com>
Date:       2005-11-23 11:45:29
Message-ID: 20051123114528.GB19383 () riva ! ucam ! org
[Download RAW message or body]

The following patch removes the udev rule that does '/sbin/modprobe
$modalias', because (a) udev has no $modalias variable (it should be
$env{MODALIAS} instead) and (b) udev installations these days generally
have a rule in the standard ruleset that does this already, and
duplicating the rule just results in an unnecessary extra invocation of
modprobe.

If you don't want to remove the rule, then please correct $modalias to
$env{modalias}.

--- udev/60-pcmcia.rules
+++ udev/60-pcmcia.rules
@@ -1,9 +1,5 @@
 # PCMCIA devices:
 #
-# modprobe $modalias loads all possibly appropriate modules
-ACTION=="add", SUBSYSTEM=="pcmcia", MODALIAS=="*", \
-		RUN+="/sbin/modprobe $modalias"
-
 # Very few CIS firmware entries (which we use for matching)
 # are so broken that we need to read out random bytes of it
 # instead of the manufactor, card or product ID. Then the

--- udev/60-pcmcia.rules.static
+++ udev/60-pcmcia.rules.static
@@ -1,9 +1,5 @@
 # PCMCIA devices:
 #
-# modprobe $modalias loads all possibly appropriate modules
-ACTION=="add", SUBSYSTEM=="pcmcia", MODALIAS=="*", \
-		RUN+="/sbin/modprobe $modalias"
-
 # Very few CIS firmware entries (which we use for matching)
 # are so broken that we need to read out random bytes of it
 # instead of the manufactor, card or product ID. Then the


Thanks,

-- 
Colin Watson                                       [cjwatson@ubuntu.com]


[prev in list] [next in list] [prev in thread] [next in thread]