[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-pci
Subject:    Re: [PATCH] dt-bindings: PCI: qcom-ep: Fix PERST register description
From:       Manivannan Sadhasivam <mani () kernel ! org>
Date:       2022-11-30 17:55:28
Message-ID: 20221130180216.GA41385 () thinkpad
[Download RAW message or body]

On Tue, Oct 18, 2022 at 11:31:15AM +0200, Johan Hovold wrote:
> The 'qcom,perst-regs' property holds a single phandle array with the
> phandle of the TCSR syscon and offsets of the two PERST registers, but
> the current schema does not capture this.
> 
> Update the binding to describe the single phandle array and its three
> elements.
> 
> Fixes: 31c9ef002580 ("dt-bindings: PCI: Add Qualcomm PCIe Endpoint controller")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>

Acked-by: Manivannan Sadhasivam <mani@kernel.org>

Thanks,
Mani

> ---
> .../devicetree/bindings/pci/qcom,pcie-ep.yaml          | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml \
> b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml index \
>                 977c976ea799..7574291646ad 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> @@ -42,13 +42,13 @@ properties:
> maxItems: 8
> 
> qcom,perst-regs:
> -    description: Reference to a syscon representing TCSR followed by the two
> -                 offsets within syscon for Perst enable and Perst separation
> -                 enable registers
> +    description: PERST TCSR registers
> $ref: "/schemas/types.yaml#/definitions/phandle-array"
> items:
> -      minItems: 3
> -      maxItems: 3
> +      - items:
> +          - description: phandle of TCSR syscon
> +          - description: offset of PERST Enable register
> +          - description: offset of PERST Separation Enable register
> 
> interrupts:
> items:
> -- 
> 2.37.3
> 

-- 
மணிவண்ணன் சதாசிவம்


[prev in list] [next in list] [prev in thread] [next in thread]