[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-pci
Subject:    Re: [PATCH] PCI: rcar, rcar-gen2: Use ARCH_RENESAS
From:       Simon Horman <horms () verge ! net ! au>
Date:       2016-02-29 0:36:18
Message-ID: 20160229003618.GA25079 () verge ! net ! au
[Download RAW message or body]

On Fri, Feb 26, 2016 at 09:22:04AM +0000, Phil Edworthy wrote:
> Hi Geert,
> 
> On 25 February 2016 08:05, Geert Uytterhoeven wrote:
> > On Thu, Feb 25, 2016 at 1:45 AM, Simon Horman
> > <horms+renesas@verge.net.au> wrote:
> > > Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.
> > >
> > > This is part of an ongoing process to migrate from ARCH_SHMOBILE to
> > > ARCH_RENESAS the motivation for which being that RENESAS seems to be a
> > more
> > > appropriate name than SHMOBILE for the majority of Renesas ARM based
> > SoCs.
> > >
> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > 
> > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > 
> > > --- a/drivers/pci/host/Kconfig
> > > +++ b/drivers/pci/host/Kconfig
> > 
> > > @@ -49,7 +49,7 @@ config PCI_RCAR_GEN2
> > >
> > >  config PCI_RCAR_GEN2_PCIE
> > >         bool "Renesas R-Car PCIe controller"
> > > -       depends on ARCH_SHMOBILE || (ARM && COMPILE_TEST)
> > > +       depends on ARCH_RENESAS || (ARM && COMPILE_TEST)
> > >         help
> > >           Say Y here if you want PCIe controller support on R-Car Gen2 SoCs.
> > 
> > BTW, this looks like a misnomer: the driver supports a compatible value for
> > R-Car H1, too ("renesas,pcie-r8a7779"), but it's not used in r8a7779.dtsi.
> IIRC, H1 PCIe support was nobbled in some way that meant you could not
> use it with any normal PCIe card. You could connect to another R-Car that
> was acting as an endpoint though.

It sounds like that might be worth documenting somewhere.

In any case, I think we could s/Gen2 // in the text above.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]