[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-pci
Subject:    RE: [PATCH v4 5/7] PCI: irqdomain: Look up IRQ domain by fwnode_handle
From:       Jake Oshins <jakeo () microsoft ! com>
Date:       2015-10-30 15:58:23
Message-ID: DM2PR0301MB123242391B393049EACC7A81AB2F0 () DM2PR0301MB1232 ! namprd03 ! prod ! outlook ! com
[Download RAW message or body]

> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> Sent: Thursday, October 29, 2015 5:28 PM
> To: Jake Oshins <jakeo@microsoft.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; KY Srinivasan
> <kys@microsoft.com>; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com; Vitaly
> Kuznetsov <vkuznets@redhat.com>; tglx@redhat.com; Haiyang Zhang
> <haiyangz@microsoft.com>; marc.zyngier@arm.com; Jiang Liu
> <jiang.liu@linux.intel.com>; Bjorn Helgaas <bhelgaas@google.com>; linux-
> pci@vger.kernel.org
> Subject: Re: [PATCH v4 5/7] PCI: irqdomain: Look up IRQ domain by
> fwnode_handle
> 
> On Fri, Oct 30, 2015 at 1:46 AM,  <jakeo@microsoft.com> wrote:
> > From: Jake Oshins <jakeo@microsoft.com>
> >
> > This patch adds a second way of finding an IRQ domain associated with
> > a root PCI bus.  After looking to see if one can be found through
> > the OF tree, it attempts to look up the IRQ domain through an
> > fwnode_handle stored in the pci_sysdata struct.
> 
> 
> > +#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
> > +       /*
> > +        * If no IRQ domain was found via the OF tree, try looking it up
> > +        * directly through the fwnode_handle.
> > +        */
> > +       if (!d) {
> > +               if (pci_fwnode(bus)) {
> 
> Isn't it the same to
> if (!d && pci_fwnode(bus))
>  d = ...
> 

Thanks.  I'll make this change and resend.

-- Jake Oshins
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]