[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-parisc
Subject:    Re: [PATCH] MODULE_DEVICE_TABLE: fix gscps2
From:       Dmitry Torokhov <dmitry.torokhov () gmail ! com>
Date:       2015-02-04 19:00:18
Message-ID: 20150204190018.GA7818 () dtor-ws
[Download RAW message or body]

On Wed, Feb 04, 2015 at 04:15:35PM +0100, Geert Uytterhoeven wrote:
> The patch "module: fix types of device tables aliases" newly requires
> that invocations of
> 
> MODULE_DEVICE_TABLE(type, name);
> 
> come *after* the definition of `name'.  That is reasonable, but gscps2
> wasn't doing this.  Fix it.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied, thank you.

> ---
> One more fix for your collection...
> 
> parisc/allmodconfig
> http://kisskb.ellerman.id.au/kisskb/buildresult/12358386/
> ---
> drivers/input/serio/gscps2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/serio/gscps2.c b/drivers/input/serio/gscps2.c
> index 8d9ba0c3827c5b2a..94ab494a6ade8d49 100644
> --- a/drivers/input/serio/gscps2.c
> +++ b/drivers/input/serio/gscps2.c
> @@ -40,7 +40,6 @@
> MODULE_AUTHOR("Laurent Canet <canetl@esiee.fr>, Thibaut Varene \
> <varenet@parisc-linux.org>, Helge Deller <deller@gmx.de>"); MODULE_DESCRIPTION("HP \
> GSC PS2 port driver"); MODULE_LICENSE("GPL");
> -MODULE_DEVICE_TABLE(parisc, gscps2_device_tbl);
> 
> #define PFX "gscps2.c: "
> 
> @@ -439,6 +438,7 @@ static struct parisc_device_id gscps2_device_tbl[] = {
> #endif
> 	{ 0, }	/* 0 terminated list */
> };
> +MODULE_DEVICE_TABLE(parisc, gscps2_device_tbl);
> 
> static struct parisc_driver parisc_ps2_driver = {
> 	.name		= "gsc_ps2",
> -- 
> 1.9.1
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[prev in list] [next in list] [prev in thread] [next in thread]