[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-parisc
Subject:    Re: [PATCH] compat_sys_ptrace conversions for parisc
From:       Roland McGrath <roland () redhat ! com>
Date:       2008-08-26 21:09:58
Message-ID: 20080826210958.2F68A154233 () magilla ! localdomain
[Download RAW message or body]

> This should probably get a little review from Rland, I've added him to
> the Cc list.  Although I suspect splitting this into at least two
> patches for compat_sys_ptrace vs the rest might make sense.

For the machines where I've done this work, I've certainly been well-served
by breaking it into many smaller incremental patches.  That would make the
meat of each patch far easier to read than this one big patch is.

It seems odd to have user_disable_single_step call ptrace_disable rather
than vice versa.  Otherwise, off hand I don't see anything particularly
suspect in the patch, but I'll admit I didn't look too close because the
one big diff is a pain to read.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]