[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-parisc
Subject:    Re: [patch] vsprintf: use new vsprintf symbolic function pointer
From:       Kyle McMartin <kyle () mcmartin ! ca>
Date:       2008-08-22 16:32:12
Message-ID: 20080822163212.GE1563 () phobos ! i ! cabal ! ca
[Download RAW message or body]

On Fri, Aug 22, 2008 at 09:34:43AM -0600, Bjorn Helgaas wrote:
> Use the '%pF' format to get rid of an "#ifdef DEBUG" and make
> some printks atomic.
> 
> This removes the last in-tree uses of print_fn_descriptor_symbol().
> I marked print_fn_descriptor_symbol() deprecated and scheduled it
> for removal next year to give time for out-of-tree modules to be
> updated.
> 
> I cc'd the parisc folks because print_fn_descriptor_symbol() is
> currently broken there (it needs to dereference the function pointer
> similar to ia64 and power).  This patch shouldn't make anything worse,
> but it means we need to fix dereference_function_descriptor() instead
> of print_fn_descriptor_symbol() to get meaningful initcall_debug
> output.
> 

Yeah, I sent a few patches a couple months ago fixing this up for
print_fn_..._symbol, but they were never applied, and I kind of forgot
about them. It only really effects me once and a while during a merge
window when I need to use initcall_debug, so it's easily forgotten.

I've got a patch, I'll send it along in a bit when one of my machines
finally boots and I can test it.

regards, Kyle
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]