[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-omap
Subject:    Re: [PATCH -next v3] gpio: omap: Remove redundant dev_err_probe() and zero value handle code
From:       Bartosz Golaszewski <brgl () bgdev ! pl>
Date:       2023-07-29 13:51:05
Message-ID: CAMRc=MdYwzrK68+9eMq8_1unP=VR5Nv-bLoEJu1UARHHLkt2uw () mail ! gmail ! com
[Download RAW message or body]

On Thu, Jul 27, 2023 at 2:41 PM Ruan Jinjie <ruanjinjie@huawei.com> wrote:
>
> There is no need to call the dev_err_probe() function directly to print
> a custom message when handling an error from platform_get_irq() function as
> it is going to display an appropriate error message in case of a failure.
>
> And the code to handle bank->irq = 0 is redundant because
> platform_get_irq() do not return 0.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
> ---

Applied, thanks!

Bart
[prev in list] [next in list] [prev in thread] [next in thread]