[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-omap
Subject: Re: [PATCH 13/17] ARM: dts: Add missing fdif node and binding for omap4
From: Laurent Pinchart <laurent.pinchart () ideasonboard ! com>
Date: 2017-08-30 17:05:59
Message-ID: 18349253.zZQUxBsrvU () avalon
[Download RAW message or body]
Hi Tony,
Thank you for the patch.
On Wednesday, 30 August 2017 18:19:49 EEST Tony Lindgren wrote:
> On omap4 we're missing the fdif node with it's related "ti,hwmods"
> property that the SoC interconnect code needs.
>
> Note that this will only show up as a bug with "doesn't have
> mpu register target base" boot errors when the legacy platform
> data is removed.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sakari Ailus <sakari.ailus@iki.fi>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> .../devicetree/bindings/media/ti-fdif.txt | 29 +++++++++++++++++++
> arch/arm/boot/dts/omap4.dtsi | 7 ++++++
> 2 files changed, 36 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/ti-fdif.txt
>
> diff --git a/Documentation/devicetree/bindings/media/ti-fdif.txt
> b/Documentation/devicetree/bindings/media/ti-fdif.txt new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/ti-fdif.txt
> @@ -0,0 +1,29 @@
> +Texas Instruments Face Detect (FDIF) binding
> +
> +FDIF can be used for face detection on Texas Instruments SoCs.
> +
> +Required properties:
> +
> +compatible: Shall be one of the following:
> + "ti,omap4-fdif"
> +
> +reg: Shall contain the device instance IO range
> +
> +interrupts: Shall contain the device instance interrupt
> +
> +
> +Optional properties:
> +
> +ti,hwmods: Shall contain the TI interconnect module name if needed
> + by the SoC
> +
> +
> +Example:
> +
> + fdif: fdif@4a10a000 {
> + compatible = "ti,omap4-fdif";
> + reg = <0x4a10a000 0x1000>;
> + interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
> + ti,hwmods = "fdif";
> + };
> +
> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> --- a/arch/arm/boot/dts/omap4.dtsi
> +++ b/arch/arm/boot/dts/omap4.dtsi
> @@ -889,6 +889,13 @@
> };
> };
>
> + fdif: fdif@4a10a000 {
> + compatible = "ti,omap4-fdif";
> + reg = <0x4a10a000 0x1000>;
> + interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
> + ti,hwmods = "fdif";
> + };
> +
> timer1: timer@4a318000 {
> compatible = "ti,omap3430-timer";
> reg = <0x4a318000 0x80>;
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic