[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-omap
Subject:    Re: drivers that require headers in mach-omap
From:       Paul Walmsley <paul () pwsan ! com>
Date:       2009-07-31 8:49:08
Message-ID: alpine.DEB.2.00.0907310245250.9998 () utopia ! booyaka ! com
[Download RAW message or body]

On Tue, 28 Jul 2009, Mike Chan wrote:

> Omap folks, how are drivers that require access to prm and cm
> registers via cm_read_mod_reg() etc... suppose to access these?
> 
> For example if drivers/usb/host/ohci-omap.c wanted to call:
> cm_read_mod_reg(OMAP3430ES2_USBHOST_MOD, CM_IDLEST);
> 
> It seems some of the headers in mach-omap2 should be in
> plat-omap/include/mach, or is there a more elegant way? The other
> alternatives are to register calls in all the board files, or #include
> ../../.. both do not seem very elegant to me.

Generally, if a device driver requires platform-specific functions, those 
functions should go into a separate file in plat-omap/ or mach-omap*/, and 
should be called via platform_data function pointers.  

For the specific case you mention, no device driver should need direct 
PRCM access.  These details change frequently between chip versions and 
are generally chip integration-specific rather than device IP-specific.


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]