[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-omap
Subject:    Re: [PATCH] OMAP: EHCI: Wrong ehci init for 2430
From:       Tony Lindgren <tony () atomide ! com>
Date:       2008-04-30 0:28:52
Message-ID: 20080430002851.GE8981 () atomide ! com
[Download RAW message or body]

* Felipe Balbi <felipe.balbi@nokia.com> [080428 03:37]:
> On Mon, Apr 28, 2008 at 03:51:11PM +0530, ext Pandita, Vikram wrote:
> > OMAP2430 does not have USB EHCI controller.
> > EHCI core was introduced with OMAP3430 ES2.0 onwards.
> > The ehci_init() call has been wrongly introduced for OMAP2430, so removing it.
> 
> Good, I was unsure about it and that's why I asked people to give the
> original patch a good review. Seems that this one came too late.
> 
> Anyway, good that you saw it :-)

Pushing today.

Tony

> > Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
> > ---
> >  arch/arm/mach-omap2/board-2430sdp.c |    2 --
> >  1 file changed, 2 deletions(-)
> > 
> > Index: linux-omap-2.6/arch/arm/mach-omap2/board-2430sdp.c
> > ===================================================================
> > --- linux-omap-2.6.orig/arch/arm/mach-omap2/board-2430sdp.c     2008-04-28 14:27:26.000000000 +0530
> > +++ linux-omap-2.6/arch/arm/mach-omap2/board-2430sdp.c  2008-04-28 15:05:34.000000000 +0530
> > @@ -36,7 +36,6 @@
> >  #include <asm/arch/mux.h>
> >  #include <asm/arch/board.h>
> >  #include <asm/arch/usb-musb.h>
> > -#include <asm/arch/usb-ehci.h>
> >  #include <asm/arch/hsmmc.h>
> >  #include <asm/arch/common.h>
> >  #include <asm/arch/keypad.h>
> > @@ -394,7 +393,6 @@ static void __init omap_2430sdp_init(voi
> > 
> >         sdp2430_flash_init();
> >         usb_musb_init();
> > -       usb_ehci_init();
> > 
> >         spi_register_board_info(sdp2430_spi_board_info,
> >                                 ARRAY_SIZE(sdp2430_spi_board_info));
> 
> -- 
> 	- Balbi
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]