[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-omap
Subject: [RFC] irq.c for OMAP3430
From: tony () atomide ! com (Tony Lindgren)
Date: 2007-05-30 8:34:24
Message-ID: 20070530133403.GC28353 () atomide ! com
[Download RAW message or body]
* Syed Mohammed, Khasim <x0khasim@ti.com> [070529 21:08]:
> Hi Tony,
>
> I have incorporated your review comments for irq.c.
>
> Please do let me know if you find any further issues with the same.
>
> Regards,
> Khasim
>
> ===============================================================
> --- linux-omap/arch/arm/mach-omap2/irq.c 2007-01-08 18:55:58.000000000 -0600
> +++ val_3430_GIT/arch/arm/mach-omap2/irq.c 2007-05-29 20:21:42.000000000 -0500
> @@ -37,11 +37,9 @@ static struct omap_irq_bank {
> } __attribute__ ((aligned(4))) irq_banks[] = {
> {
> /* MPU INTC */
> - .base_reg = IO_ADDRESS(OMAP24XX_IC_BASE),
> + .base_reg = 0,
> .nr_irqs = 96,
> - }, {
> - /* XXX: DSP INTC */
> - }
> + },
> };
>
> /* XXX: FIQ and additional INTC support (only MPU at the moment) */
> @@ -118,10 +116,16 @@ void __init omap_init_irq(void)
> for (i = 0; i < ARRAY_SIZE(irq_banks); i++) {
> struct omap_irq_bank *bank = irq_banks + i;
>
> - /* XXX */
> - if (!bank->base_reg)
> - continue;
> -
> +#ifdef CONFIG_ARCH_OMAP24XX
> + if (cpu_is_omap24xx()) {
> + bank->base_reg = IO_ADDRESS(OMAP24XX_IC_BASE);
> + }
> +#endif
> +#ifdef CONFIG_ARCH_OMAP34XX
> + if (cpu_is_omap34xx()) {
> + bank->base_reg = IO_ADDRESS(OMAP34XX_IC_BASE);
> + }
> +#endif
> omap_irq_bank_init_one(bank);
>
> nr_irqs += bank->nr_irqs;
>
Looks good, thanks!
Tony
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic