[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-omap
Subject:    [PATCH 11/11] OMAP 3430 support in include/arm/arch-omap
From:       x0khasim () ti ! com (Syed Mohammed, Khasim)
Date:       2007-05-29 13:08:32
Message-ID: 9C23CDD79DA20A479D4615857B2E2C47FF11B8 () dlee13 ! ent ! ti ! com
[Download RAW message or body]

>> +++ val_3430_GIT/include/asm-arm/arch-omap/serial.h     2007-05-25
>22:59:27.000000000 -0500
>> @@ -20,6 +20,11 @@
>>  #define OMAP_UART1_BASE                0x4806a000
>>  #define OMAP_UART2_BASE                0x4806c000
>>  #define OMAP_UART3_BASE                0x4806e000
>> +#elif defined(CONFIG_ARCH_OMAP3)
>> +/* OMAP3 serial ports */
>> +#define OMAP_UART1_BASE                0x4806a000
>> +#define OMAP_UART2_BASE                0x4806c000
>> +#define OMAP_UART3_BASE                0x49020000
>>  #endif
>
>Why not just #ifdefing UART3, as it is the only differs in base address.?
>

Tried, Looks more confusing, shown below for example:

#if defined(CONFIG_ARCH_OMAP1)
/* OMAP1 serial ports */
#define OMAP_UART1_BASE         0xfffb0000
#define OMAP_UART2_BASE         0xfffb0800
#define OMAP_UART3_BASE         0xfffb9800

#elif defined(CONFIG_ARCH_OMAP2) || defined (CONFIG_ARCH_OMAP3)
/* OMAP2 and OMAP3 serial ports */
#define OMAP_UART1_BASE         0x4806a000
#define OMAP_UART2_BASE         0x4806c000

#if defined(CONFIG_ARCH_OMAP2)
#define OMAP_UART3_BASE         0x4806e000
#elif defined(CONFIG_ARCH_OMAP3)
#define OMAP_UART3_BASE         0x49020000
#endif

#endif

The previous one is better and easier to understand, so keeping the same :)

Regards,
Khasim

[prev in list] [next in list] [prev in thread] [next in thread]