[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-omap
Subject:    [PATCH] MMC: OMAP R6 response support
From:       drzeus-list () drzeus ! cx (Pierre Ossman)
Date:       2007-01-25 9:19:47
Message-ID: 45B8CA81.5080802 () drzeus ! cx
[Download RAW message or body]

Carlos Aguiar wrote:
> Hi folks,
> 
> Regarding the commit below
> 
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=6f949909e8f9e5d7e5584dc48d9a5e060c52aed1
>  ,
> 
> the definition of response type R6 is the same as R1 and case
> 

That is intentional. All specs I have state that they have the same format.

> MMC_RSP_R6 was removed on omap.c, causing a error when inserting a SD
> card on OMAP platforms.
> 

Do you have a dump I could see?

> This error occur due following the MMC and SD specs, on CMD3, response
> type is R6 to SD cards and R1 to MMC cards.
> 
> So, I'm proposing a patch that try to solve this problem. I've tested
> it with SD and MMC cards and looks fine.
> 
> 

NAK. Opcodes should never be present in host drivers. It completely
kills forward compatibility. This should be fixed by figuring out what
the OMAP hardware does differently and do a general solution from that.

Rgds

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org


[prev in list] [next in list] [prev in thread] [next in thread]