[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ntfs-dev
Subject:    Re: [Linux-NTFS-Dev] [PATCH] typo
From:       Anton Altaparmakov <aia21 () cam ! ac ! uk>
Date:       2004-04-20 20:00:35
Message-ID: Pine.SOL.4.58.0404202058200.16414 () orange ! csi ! cam ! ac ! uk
[Download RAW message or body]

Hi,

On Mon, 19 Apr 2004, Aleksey Gorelov wrote:
>   I've been looking through ntfs implementation and noticed a 'typo'
> among sanity checks in mst.c. Here is small patch to fix it.

Ah, that is not a typo.  If you read the function comment it explains
this.  This is the relevant part of the comment:

NOTE: We consider the absence / invalidity of an update sequence array to
mean that the structure is not protected at all and hence doesn't need to
be fixed up. Thus, we return success and not failure in this case. This is
in contrast to pre_write_mst_fixup(), see below.

And hence the return 0; is not a typo it is intended.

Thanks for looking at the code.

Best regards,

	Anton
-- 
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
Linux-NTFS-Dev mailing list
Linux-NTFS-Dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-ntfs-dev
[prev in list] [next in list] [prev in thread] [next in thread]