[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-nilfs
Subject:    [PATCH 20/24] nilfs2: introduce hexdump of internal structures option
From:       Vyacheslav Dubeyko <slava () dubeyko ! com>
Date:       2013-06-17 12:26:15
Message-ID: 1371471975.2075.152.camel () slavad-ubuntu
[Download RAW message or body]

From: Vyacheslav Dubeyko <slava@dubeyko.com>
Subject: [PATCH 20/24] nilfs2: introduce hexdump of internal structures option

This patch adds CONFIG_NILFS2_DEBUG_HEXDUMP kernel configuration
option. This option enables writing in system log hexdumps of
internal structures.

Signed-off-by: Vyacheslav Dubeyko <slava@dubeyko.com>
CC: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
---
 fs/nilfs2/Kconfig |   12 ++++++++++++
 fs/nilfs2/debug.h |   39 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 51 insertions(+)

diff --git a/fs/nilfs2/Kconfig b/fs/nilfs2/Kconfig
index 39dc5c39..37fee87 100644
--- a/fs/nilfs2/Kconfig
+++ b/fs/nilfs2/Kconfig
@@ -119,6 +119,18 @@ config NILFS2_DEBUG_SHOW_SPAM
 	  option is depended implicitly from options that enable output of
 	  concrete modules of NILFS2 driver.
 
+config NILFS2_DEBUG_HEXDUMP
+	bool "Enable debugging hexdump of internal structures"
+	default n
+	help
+	  This option enables writing in system log hexdumps of internal
+	  structures. Some of big internal and raw on-disk structures can be
+	  written in system log for deep analysis of processed data related
+	  to an issue. Please, remember that hexdump output is depended
+	  implicitly from options that enable output of concrete modules of
+	  NILFS2 driver. It makes sense to log hexdumps only for modules that
+	  have enabled debugging output.
+
 endif # NILFS2_DEBUG_SUBSYSTEMS
 
 endif # NILFS2_DEBUG
diff --git a/fs/nilfs2/debug.h b/fs/nilfs2/debug.h
index 3f3b42b..3132367 100644
--- a/fs/nilfs2/debug.h
+++ b/fs/nilfs2/debug.h
@@ -109,6 +109,17 @@
  */
 #define DBG_SPAM	0x40000000
 
+/*
+ * This flag enables writing in system log hexdumps of internal
+ * structures. Some of big internal and raw on-disk structures can be
+ * written in system log for deep analysis of processed data related
+ * to an issue. Please, remember that hexdump output is depended
+ * implicitly from options that enable output of concrete modules of
+ * NILFS2 driver. It makes sense to log hexdumps only for modules that
+ * have enabled debugging output.
+ */
+#define DBG_HEX_DUMP	0x80000000
+
 #ifdef CONFIG_NILFS2_DEBUG
 
 /* Definition of flags' set for debugging */
@@ -143,6 +154,9 @@ static u32 DBG_MASK = (
 #ifdef CONFIG_NILFS2_DEBUG_SHOW_SPAM
 	DBG_SPAM |
 #endif /* CONFIG_NILFS2_DEBUG_SHOW_SPAM */
+#ifdef CONFIG_NILFS2_DEBUG_HEXDUMP
+	DBG_HEX_DUMP |
+#endif /* CONFIG_NILFS2_DEBUG_HEXDUMP */
 	0);
 
 #define NILFS2_SUBSYS_MASK	0x0FFFFFFF
@@ -172,9 +186,34 @@ static u32 DBG_MASK = (
 		} \
 	} while (0)
 
+#define nilfs2_print_hexdump(prefix, ptr, size) \
+	do { \
+		printk(KERN_DEBUG "NILFS HEXDUMP (%s, %d): %s:\n", \
+				__FILE__, __LINE__, __func__); \
+		print_hex_dump(KERN_DEBUG, prefix, \
+				DUMP_PREFIX_ADDRESS, 16, 1, \
+				ptr, size, true); \
+	} while (0)
+
+#define nilfs2_hexdump(flg, prefix, ptr, size) \
+	do { \
+		bool can_print_spam = DBG_MASK & DBG_SPAM; \
+		bool is_spam = flg & DBG_SPAM; \
+		bool can_do_hexdump = DBG_MASK & DBG_HEX_DUMP; \
+		bool is_hexdump = flg & DBG_HEX_DUMP; \
+		if ((flg & NILFS2_SUBSYS_MASK) & DBG_MASK) { \
+			if (!is_spam && (is_hexdump && can_do_hexdump)) \
+				nilfs2_print_hexdump(prefix, ptr, size); \
+			else if ((is_spam && can_print_spam) && \
+					(is_hexdump && can_do_hexdump)) \
+				nilfs2_print_hexdump(prefix, ptr, size); \
+		} \
+	} while (0)
+
 #else /* CONFIG_NILFS2_DEBUG */
 
 #define nilfs2_debug(flg, fmt, ...)	no_printk(fmt, ##__VA_ARGS__)
+#define nilfs2_hexdump(flg, prefix, ptr, size)	no_printk(prefix)
 
 #endif /* CONFIG_NILFS2_DEBUG */
 
-- 
1.7.9.5



--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]