[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-nfsv4
Subject:    Re: [PATCH 08/17] nfsd4: fix some open argument tests
From:       Neil Brown <neilb () suse ! de>
Date:       2006-06-27 5:03:54
Message-ID: 17568.48186.803163.802738 () cse ! unsw ! edu ! au
[Download RAW message or body]

On Tuesday June 27, bfields@fieldses.org wrote:
>  
> -#define TEST_ACCESS(x) ((x > 0 || x < 4)?1:0)
> -#define TEST_DENY(x) ((x >= 0 || x < 5)?1:0)
> +static int access_valid(u32 x)
> +{
> +	return (x > 0 && x < 4);
> +}
> +
> +static int deny_valid(u32 x)
> +{
> +	return (x >= 0 && x < 5);
> +}

Should these be 'inline' ??

And are there constants defined somewhere we could use instead of 0,
4, 5 ??

I'll take it like it is for now, but if you think it is appropriate to
address either of the above, I'll happy take an update patch.

NeilBrown
_______________________________________________
NFSv4 mailing list
NFSv4@linux-nfs.org
http://linux-nfs.org/cgi-bin/mailman/listinfo/nfsv4
[prev in list] [next in list] [prev in thread] [next in thread]