[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-nfsv4
Subject:    Re: [PATCH] Split fs/nfs/inode.c
From:       Trond Myklebust <trond.myklebust () fys ! uio ! no>
Date:       2006-04-28 18:06:20
Message-ID: 1146247580.8096.18.camel () lade ! trondhjem ! org
[Download RAW message or body]

On Fri, 2006-04-28 at 16:51 +0100, David Howells wrote:
> As fs/nfs/inode.c is rather large, heterogenous and unwieldy, the attached
> patch splits it up into a number of files:
> 
>  (*) fs/nfs/inode.c
> 
>      Strictly inode specific functions.
> 
>  (*) fs/nfs/super.c
> 
>      Superblock management functions for NFS and NFS4, normal access, clones
>      and referrals.  The NFS4 superblock functions _could_ move out into a
>      separate conditionally compiled file, but it's probably not worth it as
>      there're so many common bits.
> 
>  (*) fs/nfs/namespace.c
> 
>      Some namespace-specific functions have been moved here.
> 
>  (*) fs/nfs/namespace_nfs4.c
> 
>      NFS4-specific namespace functions (this could be merged into the previous
>      file).  This file is conditionally compiled.
> 
>  (*) fs/nfs/internal.h
> 
>      Inter-file declarations, plus a few simple utility functions moved from
>      fs/nfs/inode.c.
> 
>      Additionally, all the in-.c-file externs have been moved here, and those
>      files they were moved from now includes this file.
> 
> For the most part, the functions have not been changed, only some multiplexor
> functions have changed significantly.
> 
> 
> I've also:
> 
>  (*) Added some extra banner comments above some functions.
> 
>  (*) Rearranged the function order within the files to be more logical and
>      better grouped (IMO), though someone may prefer a different order.
> 
>  (*) Reduced the number of #ifdefs in .c files.
> 
>  (*) Added missing __init and __exit directives.

Looks good, but I'm not overly keen on the name namespace_nfs4.: all
other NFSv4 specific functions are named nfs4*, so let's make that
nfs4namespace.c.

Cheers,
  Trond

_______________________________________________
NFSv4 mailing list
NFSv4@linux-nfs.org
http://linux-nfs.org/cgi-bin/mailman/listinfo/nfsv4
[prev in list] [next in list] [prev in thread] [next in thread]