[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-nfs
Subject:    Re: [NFS] [PATCH] updated dir.c patched for 2.4.4 - take 2
From:       Jim Castleberry <jcastle () in-system ! com>
Date:       2001-05-17 20:00:07
[Download RAW message or body]

Christian,

The *p thing is that way because that gave the minimal code change to
fix the bug when I originally generated my patch, and it was still
that way after Trond and I iterated on the patch a couple of times.

I guess at this point it's a matter of programming style.  If enough
people object I'm not against it being changed.  Kind of like your
"int status = -0;"  ;)

jcastle


>Date: Thu, 17 May 2001 16:45:41 -0300 (BRT)
>From: Christian Robottom Reis <kiko@async.com.br>
>To: Jim Castleberry <jcastle@in-system.com>
>cc: John Alvord <jalvo@mbay.net>, <NFS@lists.sourceforge.net>
>Subject: [NFS] [PATCH] updated dir.c patched for 2.4.4 - take 2
>MIME-Version: 1.0
>
>On Thu, 17 May 2001, Jim Castleberry wrote:
>
>> You haven't done the status=0 initialization I mentioned (s.b. on line
>> 316).  But I don't see where you've done anything with start either.
>> Did you perhaps send out the wrong version of your patch?
>
>Darn, twice wrong. I need to smoke more crack. I still wonder about *p,
>though..
>
>Take care,
>--
>/\/\ Christian Reis, Senior Engineer, Async Open Source, Brazil
>~\/~ http://async.com.br/~kiko/ | [+55 16] 274 4311


_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
http://lists.sourceforge.net/lists/listinfo/nfs

[prev in list] [next in list] [prev in thread] [next in thread]