[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-nfs
Subject:    Re: [PATCH v2 01/13] svcrdma: Move send_wr to svc_rdma_op_ctxt
From:       Christoph Hellwig <hch () infradead ! org>
Date:       2017-03-30 12:06:39
Message-ID: 20170330120639.GA31144 () infradead ! org
[Download RAW message or body]

> +	svc_rdma_build_send_wr(ctxt, sge_no);
> +	send_wr = &ctxt->send_wr;
> +	if (inv_rkey) {
> +		send_wr->opcode = IB_WR_SEND_WITH_INV;
> +		send_wr->ex.invalidate_rkey = inv_rkey;
> +	}

Seems a bit odd to overwrite the work that svc_rdma_build_send_wr in
the caller.  I would propbably add this work to svc_rdma_build_send_wr.

Also any reason svc_rdma_build_send_wr can't call svc_rdma_send
directly (although it would probably need a new name then)?
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]