[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-nfs
Subject:    [PATCH] NFS: Don't leak in nfs_proc_symlink()
From:       Jesper Juhl <jj () chaosbits ! net>
Date:       2010-12-24 22:22:37
Message-ID: alpine.LNX.2.00.1012242318400.28973 () swampdragon ! chaosbits ! net
[Download RAW message or body]

Hi,

In fs/nfs/proc.c::nfs_proc_symlink() we will leak memory if either 
nfs_alloc_fhandle() or nfs_alloc_fattr() returns NULL but the other one 
doesn't.
This patch ensures memory allocated by one when the other fails is always 
released (this is safe since nfs_free_fattr() and nfs_free_fhandle() both 
call kfree which deals gracefully with NULL pointers).


Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
 proc.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/nfs/proc.c b/fs/nfs/proc.c
index 58e7f84..9e81d9b 100644
--- a/fs/nfs/proc.c
+++ b/fs/nfs/proc.c
@@ -458,7 +458,7 @@ nfs_proc_symlink(struct inode *dir, struct dentry *dentry, struct page *page,
 	fattr = nfs_alloc_fattr();
 	status = -ENOMEM;
 	if (fh == NULL || fattr == NULL)
-		goto out;
+		goto out_free;
 
 	status = rpc_call_sync(NFS_CLIENT(dir), &msg, 0);
 	nfs_mark_for_revalidate(dir);
@@ -471,6 +471,7 @@ nfs_proc_symlink(struct inode *dir, struct dentry *dentry, struct page *page,
 	if (status == 0)
 		status = nfs_instantiate(dentry, fh, fattr);
 
+out_free:
 	nfs_free_fattr(fattr);
 	nfs_free_fhandle(fh);
 out:



-- 
Jesper Juhl <jj@chaosbits.net>            http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]