[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-nfs
Subject:    Re: [PATCH] nfs: remove superfluous BUG_ON()s
From:       Trond Myklebust <Trond.Myklebust () netapp ! com>
Date:       2009-07-28 16:59:10
Message-ID: 1248800350.6205.7.camel () heimdal ! trondhjem ! org
[Download RAW message or body]

On Tue, 2009-07-28 at 17:04 +0200, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] nfs: remove superfluous BUG_ON()s
> 
> Remove duplicated BUG_ON()s from nfs[4]_create_server()
> (we make the same checks earlier in both functions).
> 
> This takes care of the following entries from Dan's list:
> 
> fs/nfs/client.c +1078 nfs_create_server(47) warning: variable derefenced before \
> check 'server->nfs_client' fs/nfs/client.c +1079 nfs_create_server(48) warning: \
> variable derefenced before check 'server->nfs_client->rpc_ops' fs/nfs/client.c \
> +1363 nfs4_create_server(43) warning: variable derefenced before check \
> 'server->nfs_client' fs/nfs/client.c +1364 nfs4_create_server(44) warning: variable \
> derefenced before check 'server->nfs_ 
> Reported-by: Dan Carpenter <error27@gmail.com>
> Cc: corbet@lwn.net
> Cc: eteo@redhat.com
> Cc: Julia Lawall <julia@diku.dk>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

Thanks! I will apply...

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[prev in list] [next in list] [prev in thread] [next in thread]