[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-nfs
Subject:    [NFS] Re: [PATCH 2.4] SGI 932676 link_path_walk refcount problem allows umount of active filesystem
From:       Marcelo Tosatti <marcelo.tosatti () cyclades ! com>
Date:       2005-03-25 19:58:56
Message-ID: 20050325195856.GB15383 () logos ! cnet
[Download RAW message or body]

On Tue, Mar 22, 2005 at 12:24:37PM +1100, Greg Banks wrote:
> G'day,
> 
> The attached patch fixes a bug in the VFS code which causes
> "Busy inodes after unmount" and a subsequent oops.

Applied, thanks.

> 
> Greg.
> -- 
> Greg Banks, R&D Software Engineer, SGI Australian Software Group.
> I don't speak for SGI.
> 

> Following an absolute symlink opens a window during which the
> filesystem containing the symlink has an outstanding dentry count
> and no outstanding vfsmount count.  A umount() of the filesystem can
> (incorrectly) proceed, resulting in the "Busy inodes after unmount"
> message and an oops shortly thereafter.
> 
> Systems using autofs-controlled NFS mounts are especially vulnerable,
> as autofs both increases the number of unmounts happening and does NFS
> mounting in response to lookups which can result in multiple-second
> vulnerability windows.  However the bug could happen on any filesystem.
> 
> This patch adds a mntget()/mntput() pair around the link following code
> (as the 2.6 code does).  Attempts to umount() during link following
> now return EBUSY.
> 
> 
> Signed-off-by: Greg Banks <gnb@melbourne.sgi.com>


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
[prev in list] [next in list] [prev in thread] [next in thread]