[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-next
Subject:    Re: [PATCH v2] drivers/of: Constify device_node->name and ->path_component_name
From:       Grant Likely <grant.likely () secretlab ! ca>
Date:       2012-11-29 16:34:16
Message-ID: 20121129163416.7CC4F3E0A04 () localhost
[Download RAW message or body]

On Wed, 28 Nov 2012 10:46:04 +1100, Michael Neuling <mikey@neuling.org> wrote:
> > Neither of these should ever be changed once set. Make them const and
> > fix up the users that try to modify it in-place. In one case
> > kmalloc+memcpy is replaced with kstrdup() to avoid modifying the string.
> > 
> > Build tested with defconfigs on ARM, PowerPC, Sparc, MIPS, x86 among
> > others.
> 
> Grant,
> 
> This breaks powerpc chroma_defconfig in next-20121127 with:
> 
> arch/powerpc/sysdev/scom.c:160:17: error: assignment discards 'const' qualifier \
> from pointer target type [-Werror] 
> The following fixes it.  The change is to generic code, so I'm not sure
> it's the right fix as it may break other configs/archs.

That is rather risky. Post it as a patch to core code, but in the mean
time I'll patch the powerpc scom code.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[prev in list] [next in list] [prev in thread] [next in thread]