[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-newbie
Subject:    Re: [PATCH 1/1] ipc/mqueue.c: Drag unneeded code out of locks
From:       Davidlohr Bueso <dave () stgolabs ! net>
Date:       2014-11-17 20:52:10
Message-ID: 1416257530.4494.0.camel () localhost
[Download RAW message or body]

On Mon, 2014-11-17 at 20:08 +0100, Manfred Spraul wrote:
> Hi Steven,
> 
> On 11/16/2014 08:40 PM, Steven Stewart-Gallus wrote:
> > Finally, please don't ignore the rest of my message. Even if my patch
> > isn't that good there are lots of ways to compromise and improve it
> > such as adding tests, annotations and making it clearer.
> 
> I think you were already given ideas how to improve the patch:
> 
> a) split the patch.
> 
> b) create test cases so that you are able to check that the code still 
> behaves as it did before

Adding/improving ipc kselftests would also be very welcome.

Thanks,
Davidlohr

--
To unsubscribe from this list: send the line "unsubscribe linux-newbie" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.linux-learn.org/faqs
[prev in list] [next in list] [prev in thread] [next in thread]