[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-netdev
Subject:    Re: [PATCH 2/4] ptp: add ptp_gettimex64any() support
From:       Richard Cochran <richardcochran () gmail ! com>
Date:       2023-09-30 21:18:32
Message-ID: ZRiQqLYpzJGbiqYX () hoboy ! vegasvil ! org
[Download RAW message or body]

On Thu, Sep 28, 2023 at 07:37:40PM -0700, Mahesh Bandewar wrote:

> diff --git a/include/uapi/linux/ptp_clock.h b/include/uapi/linux/ptp_clock.h
> index 05cc35fc94ac..1f1e98966cff 100644
> --- a/include/uapi/linux/ptp_clock.h
> +++ b/include/uapi/linux/ptp_clock.h
> @@ -69,6 +69,14 @@
>   */
>  #define PTP_PEROUT_V1_VALID_FLAGS	(0)
>  
> +enum ptp_ts_types {
> +	PTP_TS_CYCLES = 0,
> +	PTP_TS_REAL,
> +	PTP_TS_MONO,
> +	PTP_TS_RAW,
> +	PTP_TS_MAX,
> +};

There is no need for a new set of enumerated values.  Why not use the
existing clockid_t ?

Thanks,
Richard

[prev in list] [next in list] [prev in thread] [next in thread]