[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-netdev
Subject:    Re: [PATCH] r8169: fix a race between PCI probe and dev_open
From:       Linus Torvalds <torvalds () linux-foundation ! org>
Date:       2007-02-01 0:55:55
Message-ID: Pine.LNX.4.64.0701311655050.3632 () woody ! linux-foundation ! org
[Download RAW message or body]



On Wed, 31 Jan 2007, Francois Romieu wrote:

> Call chain:
> -> rtl8169_init_one
>    -> register_netdev                  (dev_open starts to race...)
>    -> rtl8169_init_phy
>       -> rtl8169_set_speed
>          -> tp->set_speed
>          -> mod_timer(&tp->timer, ...) (if netif_running() is true)
> 
> As netif_running() is true just before dev->open() is issued and the
> timer is initialized during dev->open, mod_timer() meets an uninitialized
> tp->timer and oopses.

Doesn't this basically mean that *any* use of "rtl8169_set_speed()" is 
buggy?

Anyway, I'm going to wait for somebody smarter than me to ACK this patch. 
Jeff?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]