[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-netdev
Subject:    Patch: b44.c: Always restore pci config on resume
From:       Stefan Rompf <srompf () isg ! de>
Date:       2004-05-26 21:17:30
Message-ID: 200405262317.32299.srompf () isg ! de
[Download RAW message or body]

Hi,

the Broadcom BCM4401 driver restores pci configuration on resume only when the 
device is up. On my notebook, this leads to a failure when the device is down 
during the S3 cycle. Short solution for now: Always restore pci config. Patch 
against 2.6.7rc1 attached, please apply.

Stefan

["b44-resume.diff" (text/x-diff)]

--- linux-2.6.7rc1-orig/drivers/net/b44.c	2004-05-26 23:00:59.474435392 +0200
+++ linux-2.6.7rc1/drivers/net/b44.c	2004-05-26 22:22:12.000000000 +0200
@@ -1882,11 +1882,11 @@ static int b44_resume(struct pci_dev *pd
 	struct net_device *dev = pci_get_drvdata(pdev);
 	struct b44 *bp = dev->priv;
 
+	pci_restore_state(pdev, bp->pci_cfg_state);
+
 	if (!netif_running(dev))
 		return 0;
 
-	pci_restore_state(pdev, bp->pci_cfg_state);
-
 	spin_lock_irq(&bp->lock);
 
 	b44_init_rings(bp);


[prev in list] [next in list] [prev in thread] [next in thread]