[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-mmc
Subject:    Re: [PATCH] mmc: atmel-mci: Remove preprocessor directive
From:       Linus Walleij <linus.walleij () linaro ! org>
Date:       2023-08-29 7:18:39
Message-ID: CACRpkdZKALgcN58Es_hKL1MyEKYaTezuRGyaMkkBYyfXhRpdKg () mail ! gmail ! com
[Download RAW message or body]

On Mon, Aug 28, 2023 at 12:04 PM Balamanikandan Gunasundar
<balamanikandan.gunasundar@microchip.com> wrote:

> Remove the preprocessor directive IS_ENABLED(CONFIG_MMC_ATMELMCI) while
> checking if the device is compatible with atmel,hsmci. Instead handle it in
> the if() condition. The compiler optimizes out the entire if() clause if
> the first expression in the if() clause is constant false.
>
> Signed-off-by: Balamanikandan Gunasundar <balamanikandan.gunasundar@microchip.com>
> Suggested-by: Linus Walleij <linus.walleij@linaro.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Thanks for tidying this up Balamanikandan!

Yours,
Linus Walleij
[prev in list] [next in list] [prev in thread] [next in thread]