[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-mmc
Subject:    Re: [patch 2/2] mmc: omap_hsmmc: checking for ERR_PTR instead of NULL
From:       Balaji T K <balajitk () ti ! com>
Date:       2014-01-30 13:12:35
Message-ID: 52EA4CF3.2000200 () ti ! com
[Download RAW message or body]

On Thursday 30 January 2014 05:45 PM, Dan Carpenter wrote:
> The of_get_hsmmc_pdata() function returns NULL on error, it doesn't
> return ERR_PTRs.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index bfb0dbd052c0..76dbc7b759c2 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -1761,9 +1761,8 @@ static int omap_hsmmc_probe(struct platform_device *pdev)
>   	match = of_match_device(of_match_ptr(omap_mmc_of_match), &pdev->dev);
>   	if (match) {
>   		pdata = of_get_hsmmc_pdata(&pdev->dev);
> -
> -		if (IS_ERR(pdata))
> -			return PTR_ERR(pdata);
> +		if (!pdata)
> +			return -ENOMEM;

Thanks for reporting this.
Caller needs to be fixed. I will send a patch to fix this.

>
>   		if (match->data) {
>   			const u16 *offsetp = match->data;
>

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]