[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-mmc
Subject:    Re: PATCH: sdhci.h fix typo
From:       Ben Dooks <ben-linux () fluff ! org>
Date:       2010-04-29 8:36:14
Message-ID: 20100429083614.GD2589 () trinity ! fluff ! org
[Download RAW message or body]

On Thu, Apr 29, 2010 at 04:05:06PM +0800, zhangfei gao wrote:
> Hi,
> 
> Here is one typo erro in sdhci.h, though it does not impact the stability.
> 
> Thanks
> 
> >From 1fbcb05dbab2e5e5de72060f0481a279fa3eda18 Mon Sep 17 00:00:00 2001
> From: Zhangfei Gao <zgao6@marvell.com>
> Date: Thu, 22 Apr 2010 11:25:17 +0800
> Subject: [PATCH] mmc: SDHCI_INT_DATA_MASK typo error
> 
> Signed-off-by: Zhangfei Gao <zgao6@marvell.com>
> Reviewed-by: Matt Fleming <matt@console-pimps.org>
> ---
>  drivers/mmc/host/sdhci.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
> index 842f46f..9ba4268 100644
> --- a/drivers/mmc/host/sdhci.h
> +++ b/drivers/mmc/host/sdhci.h
> @@ -127,7 +127,7 @@
>  #define  SDHCI_INT_DATA_MASK	(SDHCI_INT_DATA_END | SDHCI_INT_DMA_END | \
>  		SDHCI_INT_DATA_AVAIL | SDHCI_INT_SPACE_AVAIL | \
>  		SDHCI_INT_DATA_TIMEOUT | SDHCI_INT_DATA_CRC | \
> -		SDHCI_INT_DATA_END_BIT | SDHCI_ADMA_ERROR)
> +		SDHCI_INT_DATA_END_BIT | SDHCI_INT_ADMA_ERROR)

Hmm, how did I end up missing this one? A definite bug, SDHCI_ADMA_ERROR
value is 0x54. Currentlyt there is no INT definiton for the 0x4, and
SDHCI_INT_SPACE_AVAIL is 0x10. We end up adding SDHCI_INT_CARD_INSERT to
the list of interrupts for SDHCI_INT_DATA_MASK.

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]