[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-mm-commits
Subject:    + lib-use-seq_open_private-instead-of-seq_open.patch added to -mm tree
From:       akpm () linux-foundation ! org
Date:       2014-08-29 19:21:22
Message-ID: 5400d2b2.UKvkfZR0Wc/PRJOM%akpm () linux-foundation ! org
[Download RAW message or body]


The patch titled
     Subject: lib/dynamic_debug.c: use seq_open_private() instead of seq_open()
has been added to the -mm tree.  Its filename is
     lib-use-seq_open_private-instead-of-seq_open.patch

This patch should soon appear at
    http://ozlabs.org/~akpm/mmots/broken-out/lib-use-seq_open_private-instead-of-seq_open.patch
and later at
    http://ozlabs.org/~akpm/mmotm/broken-out/lib-use-seq_open_private-instead-of-seq_open.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Rob Jones <rob.jones@codethink.co.uk>
Subject: lib/dynamic_debug.c: use seq_open_private() instead of seq_open()

Using seq_open_private() removes boilerplate code from ddebug_proc_open().

The resultant code is shorter and easier to follow.

This patch does not change any functionality.

Signed-off-by: Rob Jones <rob.jones@codethink.co.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 lib/dynamic_debug.c |   17 ++---------------
 1 file changed, 2 insertions(+), 15 deletions(-)

diff -puN lib/dynamic_debug.c~lib-use-seq_open_private-instead-of-seq_open lib/dynamic_debug.c
--- a/lib/dynamic_debug.c~lib-use-seq_open_private-instead-of-seq_open
+++ a/lib/dynamic_debug.c
@@ -829,22 +829,9 @@ static const struct seq_operations ddebu
  */
 static int ddebug_proc_open(struct inode *inode, struct file *file)
 {
-	struct ddebug_iter *iter;
-	int err;
-
 	vpr_info("called\n");
-
-	iter = kzalloc(sizeof(*iter), GFP_KERNEL);
-	if (iter == NULL)
-		return -ENOMEM;
-
-	err = seq_open(file, &ddebug_proc_seqops);
-	if (err) {
-		kfree(iter);
-		return err;
-	}
-	((struct seq_file *)file->private_data)->private = iter;
-	return 0;
+	return seq_open_private(file, &ddebug_proc_seqops,
+				sizeof(struct ddebug_iter));
 }
 
 static const struct file_operations ddebug_proc_fops = {
_

Patches currently in -mm which might be from rob.jones@codethink.co.uk are

ipc-use-__seq_open_private-instead-of-seq_open.patch
mm-use-seq_open_private-instead-of-seq_open.patch
mm-use-__seq_open_private-instead-of-seq_open.patch
lib-use-seq_open_private-instead-of-seq_open.patch
linux-next.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]