[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-mm
Subject:    Re: [PATCH] modified memory_pressure calculation
From:       Manfred Spraul <manfred () colorfullife ! com>
Date:       2001-05-28 19:20:53
[Download RAW message or body]

Marcelo Tosatti wrote:
> 
> I disagree with the second hunk.
> 
> memory_pressure is used to calculate the size of _both_ the inactive dirty
> and clean lists.
> 
> Since you're adding the page back to the inactive dirty list, you should
> not increase memory_pressure.
>

Correct. And page_launder should increase memory_pressure fore each page
it moves back into the active list.

But I don't like the overloading of memory_pressure. Initially I thought
that one ++ is missing.

I think an additional statistic variable would be better.
[reactivation_rate, or whatever].

--
	Manfred
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/

[prev in list] [next in list] [prev in thread] [next in thread]