[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-mm
Subject:    Re: [PATCH v2 2/3] mm: Force update of mem cgroup soft limit tree on usage excess
From:       Tim Chen <tim.c.chen () linux ! intel ! com>
Date:       2021-02-27 0:56:28
Message-ID: 781634ee-ffb9-598d-fdb6-0ae6067448b7 () linux ! intel ! com
[Download RAW message or body]



On 2/26/21 12:52 AM, Michal Hocko wrote:

>>
>> Michal,
>>
>> Let's take an extreme case where memcg 1 always generate the
>> first event and memcg 2 generates the rest of 128*8-1 events
>> and the pattern repeat.
> 
> I do not follow. Events are per-memcg, aren't they?
> 	__this_cpu_read(memcg->vmstats_percpu->targets[target]);
> 	[...]
> 	__this_cpu_write(memcg->vmstats_percpu->targets[target], next);
> 

You are right. My previous reasoning is incorrect as the sampling is done per memcg.
I'll do some additional debugging on why memcg is not on the tree.

Tim 

[prev in list] [next in list] [prev in thread] [next in thread]