[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-mm
Subject:    Re: [PATCH] gcov: include linux/module.h for within_module
From:       Randy Dunlap <rdunlap () infradead ! org>
Date:       2019-03-29 18:10:49
Message-ID: eea3ce6a-732b-5c1d-9975-eddaeee21cf5 () infradead ! org
[Download RAW message or body]

On 3/29/19 11:09 AM, Nick Desaulniers wrote:
> On Fri, Mar 29, 2019 at 11:01 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> > 
> > On 3/29/19 10:45 AM, Nick Desaulniers wrote:
> > > Fixes commit 8c3d220cb6b5 ("gcov: clang support")
> > > 
> > > Cc: Greg Hackmann <ghackmann@android.com>
> > > Cc: Tri Vo <trong@android.com>
> > > Cc: Peter Oberparleiter <oberpar@linux.ibm.com>
> > > Cc: linux-mm@kvack.org
> > > Cc: kbuild-all@01.org
> > > Reported-by: kbuild test robot <lkp@intel.com>
> > > Link: https://marc.info/?l=linux-mm&m=155384681109231&w=2
> > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> > 
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > see https://lore.kernel.org/linux-mm/20190328225107.ULwYw%25akpm@linux-foundation.org/T/#mee26c00158574326e807480fc39dfcbd7bebd5fd
> >  
> > Did you test this?
> 
> Yes, built with gcc 7.3 and
> defconfig
> +
> CONFIG_GCOV_KERNEL=y
> CONFIG_ARCH_HAS_GCOV_PROFILE_ALL=y
> CONFIG_GCOV_FORMAT_4_7=y
> 
> > kernel/gcov/gcc_4_7.c includes local "gcov.h",
> > which includes <linux/module.h>, so why didn't that work or why
> > does this patch work?
> 
> Good point. May be something in the configs from 0-day bot.  Boarding
> a plane for Bangkok, but can dig further once landed.
> 
> Maybe module support was disabled?

Yes, I reported the problem with CONFIG_MODULES not enabled.


-- 
~Randy


[prev in list] [next in list] [prev in thread] [next in thread]