[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-mm
Subject:    Re: [RFC][PATCH 2/2] memcg : remove -ENOMEM at page migration.
From:       David Rientjes <rientjes () google ! com>
Date:       2012-06-29 21:41:10
Message-ID: alpine.DEB.2.00.1206291439080.11416 () chino ! kir ! corp ! google ! com
[Download RAW message or body]

On Thu, 28 Jun 2012, Kamezawa Hiroyuki wrote:

> For handling many kinds of races, memcg adds an extra charge to
> page's memcg at page migration. But this affects the page compaction
> and make it fail if the memcg is under OOM.
> 
> This patch uses res_counter_charge_nofail() in page migration path
> and remove -ENOMEM. By this, page migration will not fail by the
> status of memcg.
> 
> Reported-by: David Rientjes <rientjes@google.com>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

Acked-by: David Rientjes <rientjes@google.com>

This is a very good improvement for page migration under memory compaction 
and increases the liklihood that it will do useful work for transparent 
hugepage allocations, thanks!

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
[prev in list] [next in list] [prev in thread] [next in thread]