[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-mm
Subject:    Re: Common 04/22] [slab] Use page struct fields instead of casting
From:       David Rientjes <rientjes () google ! com>
Date:       2012-05-31 21:23:09
Message-ID: alpine.DEB.2.00.1205311422440.2764 () chino ! kir ! corp ! google ! com
[Download RAW message or body]

On Wed, 23 May 2012, Christoph Lameter wrote:

> Add fields to the page struct so that it is properly documented that
> slab overlays the lru fields.
> 
> This cleans up some casts in slab.
> 

Sounds good, but...

> Index: linux-2.6/include/linux/mm_types.h
> ===================================================================
> --- linux-2.6.orig/include/linux/mm_types.h	2012-05-22 09:05:49.716464025 -0500
> +++ linux-2.6/include/linux/mm_types.h	2012-05-22 09:21:28.532444572 -0500
> @@ -90,6 +90,10 @@ struct page {
>  				atomic_t _count;		/* Usage count, see below. */
>  			};
>  		};
> +		struct {		/* SLAB */
> +			struct kmem_cache *slab_cache;
> +			struct slab *slab_page;
> +		};
>  	};
>  
>  	/* Third double word block */

The lru fields are in the third double word block.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
[prev in list] [next in list] [prev in thread] [next in thread]