[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-mm
Subject:    Re: [PATCH/RFC] m68k/sun3: Kill pte_unmap() warnings
From:       Andreas Schwab <schwab () linux-m68k ! org>
Date:       2010-10-31 21:32:18
Message-ID: m2wroynj4t.fsf () igel ! home
[Download RAW message or body]

Geert Uytterhoeven <geert@linux-m68k.org> writes:

> Which one is preferable?
> 
> -------------------------------------------------------------------------------
> Since commit 31c911329e048b715a1dfeaaf617be9430fd7f4e ("mm: check the argument
> of kunmap on architectures without highmem"), we get lots of warnings like
> 
> arch/m68k/kernel/sys_m68k.c:508: warning: passing argument 1 of ‘kunmap' from \
> incompatible pointer type 
> As m68k doesn't support highmem anyway, open code the calls to kmap() and
> kunmap() (the latter is a no-op) to kill the warnings.

I prefer this one, it matches all architectures without CONFIG_HIGHPTE.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>


[prev in list] [next in list] [prev in thread] [next in thread]