[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-mm
Subject:    Re: [patch 0/9] Page flags V3: Cleanup and reorg
From:       Andrew Morton <akpm () linux-foundation ! org>
Date:       2008-03-28 9:08:32
Message-ID: 20080328020832.5f6f8e92.akpm () linux-foundation ! org
[Download RAW message or body]

On Tue, 18 Mar 2008 11:19:57 -0700 Christoph Lameter <clameter@sgi.com> wrote:

> A set of patches that attempts to improve page flag handling.

sh allmodconfig blows up with various unsatisfied link-time references to
swapper_space.

this:

--- a/include/linux/mm.h~a
+++ a/include/linux/mm.h
@@ -605,9 +605,12 @@ static inline struct address_space *page
 	struct address_space *mapping = page->mapping;
 
 	VM_BUG_ON(PageSlab(page));
+#ifdef CONFIG_SWAP
 	if (unlikely(PageSwapCache(page)))
 		mapping = &swapper_space;
-	else if (unlikely((unsigned long)mapping & PAGE_MAPPING_ANON))
+	else
+#endif
+	if (unlikely((unsigned long)mapping & PAGE_MAPPING_ANON))
 		mapping = NULL;
 	return mapping;
 }
_

fixes it, but it shouldn't, unless it's a cimpiler bug.  Could you
investigate please, check that we're not adding unintended code bloat for
some reason?

http://userweb.kernel.org/~akpm/cross-compilers/ has the toolchain.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
[prev in list] [next in list] [prev in thread] [next in thread]