[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-mm
Subject:    Re: [PATCH]: 2/4 mm/swap.c cleanup
From:       Nikita Danilov <nikita () clusterfs ! com>
Date:       2004-11-22 15:50:51
Message-ID: 16802.2779.846726.814048 () gargle ! gargle ! HOWL
[Download RAW message or body]

Hugh Dickins writes:
 > On Mon, 22 Nov 2004, Nikita Danilov wrote:
 > > Andrew Morton writes:
 > >  > 
 > >  > Sorry, this looks more like a dirtyup to me ;)
 > > 
 > > Don't tell me you are not great fan on comma operator abuse. :)
 > > 
 > > Anyway, idea is that by hiding complexity it loop macro, we get rid of a
 > > maze of pvec-loops in swap.c all alike.
 > > 
 > > Attached is next, more typeful variant. Compilebootentested.
 > 
 > You're scaring me, Nikita.  Those loops in mm/swap.c are easy to follow,
 > whyever do you want to obfuscate them with your own macro maze?

Because my intellectual capacity is limited, and it has little room left
for analyzing _multiple_ zone-lock-tracking sequences. It seems cleaner
to do this once, but as you put is elsewhere "it is a matter of personal
taste".

Besides, after I was recently subjected to looking at BSD kernel code, I
have morbid fear or any kind of mostly similar chunks of code
cut-n-pasted and then modified independently.

 > 
 > Ingenious for_each macros make sense where it's an idiom which is going
 > to be useful to many across the tree; but these are just a few instances
 > in a single source file.

Yes, this makes sense.

 > 
 > Please find a better outlet for your talents!

Heh, you know, from a few VM patches I have in the queue, I started
submitting least controversial ones. :)

 > 
 > Hugh

Nikita.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
[prev in list] [next in list] [prev in thread] [next in thread]