[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-mips-cvs
Subject:    MIPS: c-r4k: Fix size calc when avoiding IPIs for small icache flushes
From:       linux-mips () linux-mips ! org
Date:       2016-09-20 13:49:26
Message-ID: S23993119AbcITNt2r-sVY/20160920134929Z+1665 () eddie ! linux-mips ! org
[Download RAW message or body]

Author: Paul Burton <paul.burton@imgtec.com> Mon Sep 5 15:24:54 2016 +0100
Comitter: Ralf Baechle <ralf@linux-mips.org> Tue Sep 13 17:36:19 2016 +0200
Commit: 1178149d22b23e1eea1b5a9b5acab2fca0e8cfff
Gitweb: https://git.linux-mips.org/g/ralf/linux/1178149d22b2
Branch: master

Commit f70ddc07b637 ("MIPS: c-r4k: Avoid small flush_icache_range SMP
calls") adds checks to force use of hit-type cache ops for small icache
flushes where they are globalised & index-type cache ops aren't, in
order to avoid the overhead of IPIs in those cases. However it
calculated the size of the region being flushed incorrectly, subtracting
the end address from the start address rather than the reverse. This
would have led to an overflow with size wrapping round to some large
value, and likely to the special case for avoiding IPIs not actually
being hit.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Cc: James Hogan <james.hogan@imgtec.com>
Fixes: f70ddc07b637 ("MIPS: c-r4k: Avoid small flush_icache_range SMP calls")
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Cc: Huacai Chen <chenhc@lemote.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/14211/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

---

 arch/mips/mm/c-r4k.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[prev in list] [next in list] [prev in thread] [next in thread]