[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-mips
Subject:    Re: [PATCH v2] smp_call_function: use inline helpers instead of macros
From:       Arnd Bergmann <arnd () arndb ! de>
Date:       2017-07-26 14:50:20
Message-ID: CAK8P3a3Wch2mUGnWjYXTUR0tt0q6DqoN58q4eS5Q7shHi=iS-g () mail ! gmail ! com
[Download RAW message or body]

On Wed, Jul 26, 2017 at 4:42 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 26/07/2017 15:32, Arnd Bergmann wrote:
>> A new caller of smp_call_function() passes a local variable as the 'wait'
>> argument, and that variable is otherwise unused, so we get a warning
>> in non-SMP configurations:
>>
>> virt/kvm/kvm_main.c: In function 'kvm_make_all_cpus_request':
>> virt/kvm/kvm_main.c:195:7: error: unused variable 'wait' [-Werror=unused-variable]
>>   bool wait = req & KVM_REQUEST_WAIT;
>>
>> This addresses the warning by changing the two macros into inline functions.
>> As reported by the 0day build bot, a small change is required in the MIPS
>> r4k code for this, which then gets a warning about a missing variable.
>>
>> Fixes: 7a97cec26b94 ("KVM: mark requests that need synchronization")
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Link: https://patchwork.kernel.org/patch/9722063/
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> This is not needed anymore, I've fixed it in KVM:
>
>     commit b49defe83659cefbb1763d541e779da32594ab10
>     Author: Paolo Bonzini <pbonzini@redhat.com>
>     Date:   Fri Jun 30 13:25:45 2017 +0200
>
>     kvm: avoid unused variable warning for UP builds

Ok, that seems sufficient, thanks!

      Arnd

[prev in list] [next in list] [prev in thread] [next in thread]