[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-mips
Subject:    Re: [PATCH 3/4] MIPS: malta-time: Don't use PIT timer for cevt/csrc
From:       James Hogan <james.hogan () imgtec ! com>
Date:       2016-04-28 16:36:43
Message-ID: 20160428163643.GD2467 () jhogan-linux ! le ! imgtec ! org
[Download RAW message or body]


On Fri, Apr 22, 2016 at 09:29:07PM +0200, Ralf Baechle wrote:
> On Fri, Apr 22, 2016 at 08:23:12PM +0100, James Hogan wrote:
> 
> > >  Not everyone uses virtualisation, so it's a functional regression for 
> > > them.  Can't you lower the priority for the timer instead so that it is 
> > > not selected by default, just as it's done with other platforms providing 
> > > a choice of timers?
> > 
> > I'll look into that. Looking back at my IRC logs I suspect I meant to
> > check why the PIT was taking priority before submitting upstream, but
> > forgot.
> 
> The PIT already has a very low rating and should only be used if everything
> else fails.  Clock scaling for example would make the cycle counter
> unusable, there might be no GIC available etc.  Otoh with SMP the PIT is
> only usable as a clock source but not clock event device.

I can't even reproduce the problem any longer. Even with the PIT drivers
loaded and a message in the log about PIT clocksource it doesn't seem to
be used, so we can just drop this one anyway. I've marked this patch as
rejected in patchwork. Sorry for the noise.

Thanks
James

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]