[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-mips
Subject:    Re: [PATCH v5 2/4] printk/nmi: warn when some message has been lost in NMI context
From:       Russell King - ARM Linux <linux () arm ! linux ! org ! uk>
Date:       2016-04-27 9:34:38
Message-ID: 20160427093438.GK19428 () n2100 ! arm ! linux ! org ! uk
[Download RAW message or body]

On Thu, Apr 21, 2016 at 01:48:43PM +0200, Petr Mladek wrote:
> @@ -64,8 +65,10 @@ static int vprintk_nmi(const char *fmt, va_list args)
>  again:
>  	len = atomic_read(&s->len);
>  
> -	if (len >= sizeof(s->buffer))
> +	if (len >= sizeof(s->buffer)) {
> +		atomic_inc(&nmi_message_lost);

This should be fine - I think its reasonable to expect that no one is
using a spinlock implementation for their atomic ops for this...

-- 
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

[prev in list] [next in list] [prev in thread] [next in thread]