[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-mips
Subject:    Status about csum_partial optimization patches.
From:       cee1 <fykcee1 () gmail ! com>
Date:       2014-07-31 2:55:29
Message-ID: CAGXxSxXGpRBJm+8sYfYXN4-20OYdmJ4FgBDnPknv9uMBN9zBsQ () mail ! gmail ! com
[Download RAW message or body]

Hi all,

The csum_partial optimization patches have resided at patch-work for
quite a while:
1. http://patchwork.linux-mips.org/patch/6988/
2. http://patchwork.linux-mips.org/patch/7176/

Any comments about patch 1, can it be merged?

For patch 2, which is actually Loongson3 related and is modified from
ralf's patch: http://www.linux-mips.org/archives/linux-mips/2014-06/msg00023.html.
In patch 2, there are still two switches for Loongson 3A:
1. #define cpu_has_wsbh IS_ENABLED(CONFIG_CPU_LOONGSON3) in
cpu-feature-overrides.h
2. #if defined(_MIPS_ARCH_LOONGSON3A) in swab.h

It replaces the "#if defined(_MIPS_ARCH_LOONGSON3A)" with "#if
cpu_has_wsbh" in csum_partial.S, compared with ralf's original patch.
My question is using cpu_has_wsbh in macro is not suitable, hence it
is preferred to revert to the ralf's original patch?



-- 
Regards,

- cee1

[prev in list] [next in list] [prev in thread] [next in thread]