[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-mips
Subject: Re: [PATCH 2/7] MIPS: bcm63xx: register integrated EHCI controller
From: Sergei Shtylyov <sshtylyov () ru ! mvista ! com>
Date: 2010-01-31 13:16:17
Message-ID: 4B6582A1.6050708 () ru ! mvista ! com
[Download RAW message or body]
Hello.
Maxime Bizon wrote:
> The bcm63xx SOC has an integrated EHCI controller, this patch adds
> platform device registration and change board code to register
> EHCI device when necessary.
>
> Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
>
[...]
> diff --git a/arch/mips/bcm63xx/dev-usb-ehci.c b/arch/mips/bcm63xx/dev-usb-ehci.c
> new file mode 100644
> index 0000000..4bdd675
> --- /dev/null
> +++ b/arch/mips/bcm63xx/dev-usb-ehci.c
> @@ -0,0 +1,49 @@
> +/*
> + * This file is subject to the terms and conditions of the GNU General Public
> + * License. See the file "COPYING" in the main directory of this archive
> + * for more details.
> + *
> + * Copyright (C) 2010 Maxime Bizon <mbizon@freebox.fr>
> + */
> +
> +#include <linux/init.h>
> +#include <linux/kernel.h>
> +#include <linux/platform_device.h>
> +#include <bcm63xx_cpu.h>
> +#include <bcm63xx_dev_usb_ehci.h>
> +
> +static struct resource ehci_resources[] = {
> + {
> + /* start & end filled at runtime */
> + .flags = IORESOURCE_MEM,
> + },
> + {
> + /* start filled at runtime */
> + .flags = IORESOURCE_IRQ,
> + },
> +};
> +
> +static u64 ehci_dmamask = ~(u32)0;
>
Should be DMA_BIT_MASK(32).
> +
> +static struct platform_device bcm63xx_ehci_device = {
> + .name = "bcm63xx_ehci",
> + .id = 0,
> + .num_resources = ARRAY_SIZE(ehci_resources),
> + .resource = ehci_resources,
> + .dev = {
> + .dma_mask = &ehci_dmamask,
> + .coherent_dma_mask = 0xffffffff,
>
Same here...
> + },
> +};
> +
> +int __init bcm63xx_ehci_register(void)
> +{
> + if (!BCMCPU_IS_6358())
> + return 0;
> +
> + ehci_resources[0].start = bcm63xx_regset_address(RSET_EHCI0);
> + ehci_resources[0].end = ehci_resources[0].start;
> + ehci_resources[0].end += RSET_EHCI_SIZE - 1;
>
Why not do it in a single statement? Besides you could initialize the
field with that, and then do
ehci_resources[0].end += ehci_resources[0].start;
WBR, Sergei
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic