[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-mips
Subject:    Re: [PATCH 0/6] Alchemy updates for 2.6.30
From:       Sergei Shtylyov <sshtylyov () ru ! mvista ! com>
Date:       2009-03-29 11:02:21
Message-ID: 49CF553D.7070903 () ru ! mvista ! com
[Download RAW message or body]

Hello.

Manuel Lauss wrote:

> Here is another set of patches which aim to improve Alchemy and DB1200 support.
> (doesn't apply against Kevin Hickey's DB1300 patches)
> 

[...]

> #5    I dislike the alchemy/common/platform.c file because it makes passing
> platform data to drivers ugly (the platdata struct and the consumer
> are in different files)
> 

   I think it's rather smart scheme -- prevents duplication. Please 
don't change it.

> and I also don't like the fact that every conceivable piece of alchemy hardware has \
> a driver registered whether I like it or not.

   Only platform device, not the driver. User entirely controls what 
drivers are built.

> To not change existing behaviour, the platform.c file is now invoked by the board \
> Makefiles instead of the one in common/.

WBR, Sergei


[prev in list] [next in list] [prev in thread] [next in thread]