[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-media
Subject:    [PATCH] cec/core: clarify rx-arb-lost usage message
From:       Hans Verkuil <hverkuil () xs4all ! nl>
Date:       2021-03-31 8:32:12
Message-ID: 4e09f4c8-d5b4-4234-d183-10a99271e4c1 () xs4all ! nl
[Download RAW message or body]

The rx-arb-lost error injection command only works with <op> set to 'any'.
Explicitly say so in the usage message.

Also use [] to indicate that the <poll> argument is optional.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
diff --git a/Documentation/userspace-api/media/cec/cec-pin-error-inj.rst \
b/Documentation/userspace-api/media/cec/cec-pin-error-inj.rst index \
                064c8c5a1943..b0efce40471f 100644
--- a/Documentation/userspace-api/media/cec/cec-pin-error-inj.rst
+++ b/Documentation/userspace-api/media/cec/cec-pin-error-inj.rst
@@ -44,7 +44,7 @@ error injection status::
 	#   <op>[,<mode>] rx-low-drive <bit>   force a low-drive condition at this bit \
position  #   <op>[,<mode>] rx-add-byte          add a spurious byte to the received \
CEC message  #   <op>[,<mode>] rx-remove-byte       remove the last byte from the \
                received CEC message
-	#   <op>[,<mode>] rx-arb-lost <poll>   generate a POLL message to trigger an \
arbitration lost +	#    any[,<mode>] rx-arb-lost [<poll>] generate a POLL message to \
trigger an arbitration lost  #
 	# TX error injection settings:
 	#   tx-ignore-nack-until-eom           ignore early NACKs until EOM
diff --git a/drivers/media/cec/core/cec-pin-error-inj.c \
b/drivers/media/cec/core/cec-pin-error-inj.c index c0088d3b8e3d..fc0968b9d40e 100644
--- a/drivers/media/cec/core/cec-pin-error-inj.c
+++ b/drivers/media/cec/core/cec-pin-error-inj.c
@@ -277,7 +277,7 @@ int cec_pin_error_inj_show(struct cec_adapter *adap, struct \
seq_file *sf)  seq_puts(sf, "#   <op>[,<mode>] rx-low-drive <bit>   force a low-drive \
condition at this bit position\n");  seq_puts(sf, "#   <op>[,<mode>] rx-add-byte      \
add a spurious byte to the received CEC message\n");  seq_puts(sf, "#   <op>[,<mode>] \
                rx-remove-byte       remove the last byte from the received CEC \
                message\n");
-	seq_puts(sf, "#   <op>[,<mode>] rx-arb-lost <poll>   generate a POLL message to \
trigger an arbitration lost\n"); +	seq_puts(sf, "#    any[,<mode>] rx-arb-lost \
[<poll>] generate a POLL message to trigger an arbitration lost\n");  seq_puts(sf, \
"#\n");  seq_puts(sf, "# TX error injection settings:\n");
 	seq_puts(sf, "#   tx-ignore-nack-until-eom           ignore early NACKs until \
EOM\n");


[prev in list] [next in list] [prev in thread] [next in thread]